Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposing SingleAssignmentDisposableValue and making it ICancelable #1630

Merged
merged 4 commits into from
Apr 19, 2023
Merged

exposing SingleAssignmentDisposableValue and making it ICancelable #1630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d980c44
exposing SingleAssignmentDisposableValue and making it ICancelable
Fijo Oct 30, 2021
f4e7dcf
added SingleAssignmentDisposableValue to ApiApprovalTests.Core.verifi…
Fijo Oct 31, 2021
0be6222
rid SingleAssignmentDisposableValue of ICancelable
Fijo Apr 18, 2023
901ffb0
updated approved signature of SingleAssignmentDisposableValue
Fijo Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Rx.NET/Source/src/System.Reactive/Disposables/SingleAssignmentDisposableValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace System.Reactive.Disposables
/// Represents a disposable resource which only allows a single assignment of its underlying disposable resource.
/// If an underlying disposable resource has already been set, future attempts to set the underlying disposable resource will throw an <see cref="InvalidOperationException"/>.
/// </summary>
internal struct SingleAssignmentDisposableValue
public struct SingleAssignmentDisposableValue
{
private IDisposable? _current;

Expand Down
8 changes: 7 additions & 1 deletion Rx.NET/Source/tests/Tests.System.Reactive.ApiApprovals/Api/ApiApprovalTests.Core.verified.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,12 @@ public SingleAssignmentDisposable() { }
public bool IsDisposed { get; }
public void Dispose() { }
}
public struct SingleAssignmentDisposableValue
{
public System.IDisposable? Disposable { get; set; }
public bool IsDisposed { get; }
public void Dispose() { }
}
public abstract class StableCompositeDisposable : System.IDisposable, System.Reactive.Disposables.ICancelable
{
protected StableCompositeDisposable() { }
Expand Down Expand Up @@ -3152,4 +3158,4 @@ public void Start<TStateMachine>(ref TStateMachine stateMachine)
where TStateMachine : System.Runtime.CompilerServices.IAsyncStateMachine { }
public static System.Runtime.CompilerServices.TaskObservableMethodBuilder<T> Create() { }
}
}
}