Merge pull request #75718 from dibarbet/related_documents_sg

Do not include source generated documents in related document results
dotnet · Nov 4, 2024 · f2eab90 · f2eab90
2 parents 985a2a3 + ba3372b
commit f2eab90
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/src/Features/Core/Portable/RelatedDocuments/AbstractRelatedDocumentsService.cs b/src/Features/Core/Portable/RelatedDocuments/AbstractRelatedDocumentsService.cs
@@ -135,7 +135,7 @@ void ProduceItems(
             foreach (var syntaxReference in symbol.DeclaringSyntaxReferences)
             {
                 var documentId = solution.GetDocument(syntaxReference.SyntaxTree)?.Id;
-                if (documentId != null && seenDocumentIds.Add(documentId))
+                if (documentId != null && !documentId.IsSourceGenerated && seenDocumentIds.Add(documentId))
                     callback(documentId);
             }
         }

diff --git a/src/LanguageServer/ProtocolUnitTests/RelatedDocuments/RelatedDocumentsTests.cs b/src/LanguageServer/ProtocolUnitTests/RelatedDocuments/RelatedDocumentsTests.cs
@@ -9,6 +9,7 @@
 using Microsoft.CodeAnalysis.LanguageServer.Handler;
 using Roslyn.LanguageServer.Protocol;
 using Roslyn.Test.Utilities;
+using Roslyn.Test.Utilities.TestGenerators;
 using Roslyn.Utilities;
 using Xunit;
 using Xunit.Abstractions;
@@ -174,4 +175,39 @@ class Y
 
         AssertJsonEquals(results2, expectedResult);
     }
+
+    [Theory, CombinatorialData]
+    public async Task DoesNotIncludeSourceGeneratedDocuments(bool mutatingLspWorkspace, bool useProgress)
+    {
+        var source =
+            """
+            namespace M
+            {
+                class A
+                {
+                    public {|caret:|}B b;
+                }
+            }
+            """;
+        var generated =
+            """
+            namespace M
+            {
+                class B
+                {
+                }
+            }
+            """;
+
+        await using var testLspServer = await CreateTestLspServerAsync(source, mutatingLspWorkspace);
+        await AddGeneratorAsync(new SingleFileTestGenerator(generated), testLspServer.TestWorkspace);
+
+        var project = testLspServer.TestWorkspace.CurrentSolution.Projects.Single();
+        var results = await RunGetRelatedDocumentsAsync(
+            testLspServer,
+            project.Documents.First().GetURI(),
+            useProgress: useProgress);
+
+        Assert.Empty(results);
+    }
 }