Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable EnC in presence of C# 7 switch statement #12380

Closed
tmat opened this issue Jul 7, 2016 · 4 comments
Closed

Disable EnC in presence of C# 7 switch statement #12380

tmat opened this issue Jul 7, 2016 · 4 comments
Assignees
@jcouv
Labels
Area-Compilers Area-Interactive Feature - Pattern Matching Pattern Matching Interactive-EnC Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
2.0 (Preview 5)

Comments

@tmat
Copy link
Member

tmat commented Jul 7, 2016 •
edited by gafter
Loading

The compiler should provide a helper method that checks the type of the switch expression and determines whether the switch has C# 6 semantics or C# 7 semantics. In the latter case we need to report a rude edit until we have proper EnC support.
@gafter
Copy link
Member

gafter commented Jul 7, 2016

Specifically, when the converted switch expression isn't a C# 6 switchable type.

@gafter gafter self-assigned this Jul 7, 2016
@tmat tmat modified the milestones: 2.0 (Preview 4), 2.0 (RC) Jul 7, 2016
@gafter gafter added the Feature - Pattern Matching Pattern Matching label Jul 7, 2016
@gafter
Copy link
Member

gafter commented Jul 7, 2016

@jaredpar @AlekseyTs @agocke FYI

@jaredpar
Copy link
Member

jaredpar commented Jul 7, 2016

Do we have a bug tracking ENC work being completed here in the future?

@gafter gafter mentioned this issue Jul 11, 2016
Closed
@gafter gafter modified the milestones: 2.0 (RC), 2.0 (RTM) Jul 18, 2016
@gafter gafter modified the milestones: 2.0 (RTM), 2.0 (RC) Aug 8, 2016
@tmat tmat mentioned this issue Aug 9, 2016
Closed
13 tasks
@gafter gafter modified the milestones: 2.0 (RC), 2.0 (Preview 5) Aug 9, 2016
@gafter gafter assigned jaredpar and unassigned gafter Aug 31, 2016
@jaredpar jaredpar assigned jcouv and unassigned jaredpar Sep 8, 2016
@jcouv
Copy link
Member

jcouv commented Sep 13, 2016

With PR #13754, edits are blocked in any method that contains a switch statement with C# 7 semantics (before or after the edit).

@jcouv jcouv added 4 - In Review A fix for the issue is submitted for review. Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 3 - Working 4 - In Review A fix for the issue is submitted for review. labels Sep 13, 2016
@jcouv jcouv closed this as completed Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcouv jcouv

Labels
Area-Compilers Area-Interactive Feature - Pattern Matching Pattern Matching Interactive-EnC Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
2.0 (Preview 5)
Development

No branches or pull requests
4 participants
@tmat @jaredpar @gafter @jcouv