Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VisualStudioWorkspaceDiagnosticAnalyzerProviderService should fail gracefully #35138

Closed
sharwell opened this issue Apr 19, 2019 · 3 comments
Closed

VisualStudioWorkspaceDiagnosticAnalyzerProviderService should fail gracefully #35138

sharwell opened this issue Apr 19, 2019 · 3 comments
Assignees
@sharwell
Labels
Area-IDE Concept-Continuous Improvement Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
17.4 P3

Comments

@sharwell
Copy link
Member

Version Used: 7d1eef2

Currently a failure in the constructor causes Visual Studio to crash. #34454 reduces but does not eliminate the chances of this occurring. This implementation should be updated to throw an exception from GetHostDiagnosticAnalyzerPackages() rather than crash the process in the constructor.

🔗 Identified during review of #34454
🔗 This is related to #35137 and should probably be fixed at the same time
@sharwell sharwell self-assigned this Apr 19, 2019
This was referenced Apr 19, 2019
Closed
Merged
@jinujoseph jinujoseph added this to the Backlog milestone May 1, 2019
@CyrusNajmabadi
Copy link
Member

Neither VisualStudioWorkspaceDiagnosticAnalyzerProviderService nor GetHostDiagnosticAnalyzerPackages seem to exist anymore. Closing out.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2023
@CyrusNajmabadi CyrusNajmabadi added the Resolution-Not Reproducible The described behavior could not be reproduced by developers label Feb 10, 2023
@sharwell
Copy link
Member Author

sharwell commented Feb 21, 2023 •
edited
Loading

The type appears to be removed in a6289eb renamed in 44fccc1

@sharwell
Copy link
Member Author

This issue was fixed by #63912 (specifically by the addition of a factory IVisualStudioDiagnosticAnalyzerProviderFactory)

@sharwell sharwell added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed Resolution-Not Reproducible The described behavior could not be reproduced by developers labels Feb 21, 2023
@sharwell sharwell modified the milestones: Backlog, 17.4 P3 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-IDE Concept-Continuous Improvement Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
17.4 P3
Development

No branches or pull requests
3 participants
@sharwell @CyrusNajmabadi @jinujoseph