-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make IEditorFormattingService public #50221
Comments
If you just move the types, you can add a type forwarder to avoid breaking consumers. Also any consumers using restricted IVT proxies will not break if you leave the proxies in the current location. |
The namespace is changing as well. And even if I just moved the types, I'd still like to bring this for consideration :). |
Is this still needed @333fred ? |
Well, I'm not sure what service replaced |
Closing as this type doesn't exist anymore. |
We should consider making
IEditorFormattingService
public under the Features layer. Today, this component is internal in the EditorFeatures layer, and used via IVT by both F# and TS, and used by our on LSP implementation. In order to facilitate making LSP depend only on the Features layer, I've created a PR (#50222) to move the implementation into the Features layer, but due to the afformentioned IVTs, it will require coordination to make sure we don't break the VS build. I'd like us to consider, at the same time, making this a public interface as it exists today, which both removes one of our many IVTs and would allow omnisharp to take advantage of the same formatting that we have in VS.@sharwell @CyrusNajmabadi I'd like to bring this to the IDE design review, could you please schedule it whenever it fits?
The text was updated successfully, but these errors were encountered: