Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IEditorFormattingService public #50221

Closed
333fred opened this issue Jan 4, 2021 · 5 comments
Closed

Make IEditorFormattingService public #50221

333fred opened this issue Jan 4, 2021 · 5 comments
Assignees
Labels
Area-IDE Concept-API This issue involves adding, removing, clarification, or modification of an API.
Milestone

Comments

@333fred
Copy link
Member

333fred commented Jan 4, 2021

We should consider making IEditorFormattingService public under the Features layer. Today, this component is internal in the EditorFeatures layer, and used via IVT by both F# and TS, and used by our on LSP implementation. In order to facilitate making LSP depend only on the Features layer, I've created a PR (#50222) to move the implementation into the Features layer, but due to the afformentioned IVTs, it will require coordination to make sure we don't break the VS build. I'd like us to consider, at the same time, making this a public interface as it exists today, which both removes one of our many IVTs and would allow omnisharp to take advantage of the same formatting that we have in VS.

@sharwell @CyrusNajmabadi I'd like to bring this to the IDE design review, could you please schedule it whenever it fits?

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 4, 2021
@sharwell
Copy link
Member

sharwell commented Jan 4, 2021

If you just move the types, you can add a type forwarder to avoid breaking consumers. Also any consumers using restricted IVT proxies will not break if you leave the proxies in the current location.

@333fred
Copy link
Member Author

333fred commented Jan 4, 2021

If you just move the types

The namespace is changing as well. And even if I just moved the types, I'd still like to bring this for consideration :).

@jinujoseph jinujoseph added Concept-API This issue involves adding, removing, clarification, or modification of an API. Need Design Review The end user experience design needs to be reviewed and approved. and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 5, 2021
@jinujoseph jinujoseph added this to the Backlog milestone Jan 5, 2021
@CyrusNajmabadi
Copy link
Member

Is this still needed @333fred ?

@CyrusNajmabadi CyrusNajmabadi added the Need More Info The issue needs more information to proceed. label Mar 7, 2023
@333fred
Copy link
Member Author

333fred commented Mar 8, 2023

Well, I'm not sure what service replaced IEditorFormattingService (as it appears to have been removed), but if it's not public, I would still like it to be so that O# can take advantage of it.

@ghost ghost added untriaged Issues and PRs which have not yet been triaged by a lead and removed Need More Info The issue needs more information to proceed. labels Mar 8, 2023
@arunchndr arunchndr removed the untriaged Issues and PRs which have not yet been triaged by a lead label Aug 15, 2023
@sharwell sharwell moved this to In Queue in IDE: Design review Aug 22, 2023
@CyrusNajmabadi CyrusNajmabadi removed the Need Design Review The end user experience design needs to be reviewed and approved. label Oct 26, 2024
@CyrusNajmabadi CyrusNajmabadi moved this from In Queue to Complete in IDE: Design review Oct 26, 2024
@CyrusNajmabadi
Copy link
Member

Closing as this type doesn't exist anymore.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Concept-API This issue involves adding, removing, clarification, or modification of an API.
Projects
Status: Complete
Development

No branches or pull requests

6 participants