Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go To Base/Implementation should be more flexible when signatures do not match #57110

Closed
tmat opened this issue Oct 12, 2021 · 2 comments · Fixed by #75901
Closed

Go To Base/Implementation should be more flexible when signatures do not match #57110

tmat opened this issue Oct 12, 2021 · 2 comments · Fixed by #75901
Labels
Area-IDE help wanted The issue is "up for grabs" - add a comment if you are interested in working on it

Comments

@tmat
Copy link
Member

tmat commented Oct 12, 2021

Currently Go To Base invoked on the override does not find the base method when their signatures do not match exactly.
It would be useful if the feature still worked, finding approximate match (e.g. by name) when they don't, similarly to FAR.

class C
{
    public virtual void F(bool x)
    {
    }
}

class D : C
{
    public override void F(int x)
    {
    }
}
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 12, 2021
@tmat tmat removed the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 12, 2021
@CyrusNajmabadi
Copy link
Member

Note: we entirely use the compiler here. We go directly to the symbol model to answer this. If we wanted to support this it would be nice if it were through compiler error tolerance.

@CyrusNajmabadi
Copy link
Member

We would take a targeted community pr here.

@CyrusNajmabadi CyrusNajmabadi added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Oct 22, 2024
@github-project-automation github-project-automation bot moved this to InQueue in Small Fixes Oct 22, 2024
@github-project-automation github-project-automation bot moved this from InQueue to Completed in Small Fixes Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

2 participants