Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IImplementInterfaceService is implemented by calling a code action, but it should be the other way around #60990

Closed
tmat opened this issue Apr 27, 2022 · 1 comment · Fixed by #74320

Comments

@tmat
Copy link
Member

tmat commented Apr 27, 2022

As a general rule Code Actions should be built on top of feature services, not the other way around.
The inversion adds dependencies to the feature implementation on Code Action infrastructure that shouldn't be necessary.
For example, moving the feature implementation out of proc would not be currently possible with this dependency.

Tracking TODOs in source.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 27, 2022
@tmat
Copy link
Member Author

tmat commented Apr 27, 2022

@CyrusNajmabadi FYI

@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 28, 2022
@jinujoseph jinujoseph added this to the Backlog milestone Apr 28, 2022
@CyrusNajmabadi CyrusNajmabadi self-assigned this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants