Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully remove parameter null-checking implementation #61390

Closed
RikkiGibson opened this issue May 18, 2022 · 0 comments · Fixed by #61397
Closed

Fully remove parameter null-checking implementation #61390

RikkiGibson opened this issue May 18, 2022 · 0 comments · Fixed by #61397
Assignees
Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality Feature - Param Null Checking
Milestone

Comments

@RikkiGibson
Copy link
Contributor

There are a lot of conflicts when trying to automatically revert parameter null-checking in the compiler, and it was done somewhat concurrently with some parser error tolerance improvements, etc. Some combination of automatic and hand-reverting is probably the best way to do it.

We also need to decide what to do with the editor feature to adopt parameter null checking as described in dotnet/runtime#68326 (comment).

@RikkiGibson RikkiGibson self-assigned this May 18, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels May 18, 2022
@RikkiGibson RikkiGibson added this to the Compiler.Next milestone May 18, 2022
@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label May 19, 2022
@sharwell sharwell added the Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality label May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality Feature - Param Null Checking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants