-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextDocument.Folders is always empty for additional files #65589
Comments
This is related to #44131. Most likely due to the fact that IWorkspaceProjectContext.AddAdditionalFile does not accept folders (unlike IWorkspaceProjectContext.AddSourceFile). XAML intellisense needs to know project relative paths. For example, in order to display completion for
|
@jasonmalinowski can you please take a look :) |
I think this recently came up too in the replacement for IWorkspaceProjectContext that we were working on with @tmeschter -- we weren't doing link file support (or something equivalent) for additional files since we didn't really have any idea somebody would have a need for them. That said, I'm still confused on the scenario here @etvorun -- the existing XAML compiler also consumes link directives to handle things like this at the MSBuild layer? Because Roslyn doesn't use these folders other than when doing a few refactorings and placing new files on disk. It's not something we use to impact our semantics at all. |
Closing this issue as we've seen no reply to the request for more information. If you are able to get the requested information, please add it to the issue and we will retriage it. |
@jasonmalinowski
To show intellisense when editing |
@arkalyanms for scheduling - XAML needs this for their LSP implementation |
Our workspace model always allowed this at the document level, we just never had a request for it until recently for some XAML support. This adds support for legacy project systems in VS and the base C# extension project system. Changes will need to be made in other repos for the CPS-based project systems to consume the APIs being added here. Partially fixes dotnet#65589
Version Used: 4.300.22.22804
Steps to Reproduce:
MauiRepro.zip
Expected Behavior: TextDocument.Folders contains folders matching folder structure in solution explorer
Actual Behavior: TextDocument.Folders always contains 0 items
Note: *.cs files have valid Folders for plain and linked items; empty for *.cs files from SharedMaui project.
The text was updated successfully, but these errors were encountered: