Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull method up to interface doesn't show interface name when method name is too long (matters when multiple interfaces) #70316

Closed
vsfeedback opened this issue Oct 10, 2023 · 1 comment · Fixed by #75643
Labels

Comments

@vsfeedback
Copy link

vsfeedback commented Oct 10, 2023

This issue has been moved from a ticket on Developer Community.


[severity:Other]
When a method has a long name, which is undesirable but it happens, it becomes impossible to know which interface one is attempting to pull a method up to with the 'Pull method up to interface' quick refactor.

image

image

Some suggestions when hovering over an option:

  • The name of the interface be displayed in the preview view that pops up. (e.g Lines 7 to 9 of ISomeInterface). Sometimes you could tell the context from other methods that appear in the interface preview but not always.
  • The method name shortened like:
    Pull GetObjectFrom... up to ISomeInterface
  • A normal tooltip could appear on hover of an option with the full unabbreviated text.

Original Comments

Feedback Bot on 10/9/2023, 08:52 PM:

(private comment, text removed)


Original Solutions

(no solutions)

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 10, 2023
@sharwell
Copy link
Member

sharwell commented Oct 10, 2023

For the nested menu case, it seems like the method name would not be necessary at all. It's already showing on the parent menu item.

@dotnet-policy-service dotnet-policy-service bot removed the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants