Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roslyn needs to move to System.Text.Json for LSP messages. #72867

Closed
CyrusNajmabadi opened this issue Apr 3, 2024 · 0 comments · Fixed by #73207
Closed

Roslyn needs to move to System.Text.Json for LSP messages. #72867

CyrusNajmabadi opened this issue Apr 3, 2024 · 0 comments · Fixed by #73207
Assignees
@CyrusNajmabadi @dibarbet
Labels
Area-Analyzers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality

Comments

@CyrusNajmabadi
Copy link
Member

Newtonsoft is much heavier and there are nice wins we can get by moving to that. This will help with the regressions we're seeing moving to LSP pull diagnostics.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 3, 2024
@sharwell sharwell added the Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality label Apr 5, 2024
@arunchndr arunchndr removed the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 19, 2024
@DoctorKrolic DoctorKrolic mentioned this issue May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CyrusNajmabadi CyrusNajmabadi

@dibarbet dibarbet

Labels
Area-Analyzers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch Roslyn protocol types to System.Text.Json serialization dibarbet/roslyn
4 participants
@sharwell @CyrusNajmabadi @dibarbet @arunchndr