Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider deriving DiagnosticsPass from BoundTreeWalkerWithStackGuardWithoutRecursionOnTheLeftOfBinaryOperator. #75319

Open
AlekseyTs opened this issue Oct 1, 2024 · 0 comments
Open

Consider deriving DiagnosticsPass from BoundTreeWalkerWithStackGuardWithoutRecursionOnTheLeftOfBinaryOperator. #75319

AlekseyTs opened this issue Oct 1, 2024 · 0 comments
Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Milestone
17.13 P2

Comments

@AlekseyTs
Copy link
Contributor

That should allow removing this override and simplifying VisitBinaryOperator. See #74317 (comment).

We should wait for #75212 to merge and deal with VisitBinaryPattern as well.
@AlekseyTs AlekseyTs added Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality labels Oct 1, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 1, 2024
@AlekseyTs AlekseyTs mentioned this issue Oct 1, 2024
Merged
@jaredpar jaredpar added this to the 17.13 milestone Oct 1, 2024
@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label Nov 12, 2024
@arunchndr arunchndr modified the milestones: 17.13, 17.13 P2 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Projects
None yet
Milestone
17.13 P2
Development

No branches or pull requests
4 participants
@jaredpar @AlekseyTs @jcouv @arunchndr