Add NuGet and analyzer config scenarios to SG cookbook #45261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/roslyn-compiler for review please :) |
RikkiGibson
approved these changes
Jun 17, 2020
jaredpar
reviewed
Jun 18, 2020
| public void Execute(SourceGeneratorContext context) | ||
| { | ||
| // check that the users compilation references the expected library | ||
| if(!context.Compilation.ReferencedAssemblyNames.Any(ai => ai.Name.StartsWith("Newtonsoft.Json"))) |
There was a problem hiding this comment.
Suggested change
| if(!context.Compilation.ReferencedAssemblyNames.Any(ai => ai.Name.StartsWith("Newtonsoft.Json"))) | |
| if (!context.Compilation.ReferencedAssemblyNames.Any(ai => ai.Name.StartsWith("Newtonsoft.Json"))) |
There was a problem hiding this comment.
Instead of StartsWith should use a full equality check
| } | ||
| ``` | ||
|
|
||
| However, any *compile-time* dependencies, that is, used by the generator while it is is running, must be packaged directly alongside the generator assembly inside the generator NuGet package. There are no automatic facilities for this, and you will need to manually specify the dependencies to include. |
There was a problem hiding this comment.
Think this is a bit confusing because there are two interpretations of compile-time here: when the generator is compiled or when the code consuming the generator is compiled. Would be clearer to express this scenario as the generator execution.
jaredpar
approved these changes
Jun 18, 2020
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.