Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.editorconfig only shows as dirty with changes #68021

Merged
merged 1 commit into from
May 1, 2023

Conversation

beccamc
Copy link
Contributor

@beccamc beccamc commented Apr 28, 2023

Current implementation shows the file as dirty on open. This is because in SynchronizeSettings the updateText ran every time the method executed. This PR updates SynchronizeSettings to only run the text updated when the underlying .editorconfig text has changed.

editorconfig

@beccamc beccamc requested a review from a team as a code owner April 28, 2023 19:21
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 28, 2023
@beccamc beccamc enabled auto-merge May 1, 2023 15:19
@beccamc beccamc merged commit 12c7d96 into dotnet:main May 1, 2023
@ghost ghost added this to the Next milestone May 1, 2023
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants