Add BuildOnlyDiagnosticIds LSP request handler #69475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work towards dotnet/vscode-csharp#5728 Exposes an LSP API to fetch build-only diagnostic IDs for the given solution snapshot. This API will be invoked from VSCode C# extension on execution of explicit build/rebuild commands to separate out build-only and live diagnostics. See dotnet/vscode-csharp#5728 (comment) for details.
dotnet-issue-labeler
bot
added
the
untriaged
mavasani
added a commit
to mavasani/vscode-csharp
that referenced
this pull request
Aug 11, 2023
Work towards dotnet#5728. Follow-up to dotnet/roslyn#69475. C# extension can now invoke `getBuildOnlyDiagnosticIds` API after each explicit build/rebuild command to identify build-only diagnostic IDs.
genlu
reviewed
Aug 11, 2023
src/Features/LanguageServer/Protocol/Handler/Diagnostics/BuildOnlyDiagnosticIdsHandler.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Handler/Diagnostics/BuildOnlyDiagnosticIdsHandler.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Handler/Diagnostics/BuildOnlyDiagnosticIdsHandler.cs
Outdated
Show resolved
Hide resolved
… the solution + address feedback
|
ping @genlu @CyrusNajmabadi for review |
|
@genlu @CyrusNajmabadi can you please review? |
beccamc
approved these changes
Sep 21, 2023
ghost
added this to the | internal sealed class BuildOnlyDiagnosticIdsHandler( | ||
| DiagnosticAnalyzerInfoCache.SharedGlobalCache globalCache, | ||
| [ImportMany] IEnumerable<Lazy<ILspBuildOnlyDiagnostics, ILspBuildOnlyDiagnosticsMetadata>> compilerBuildOnlyDiagnosticsProviders) | ||
| : ILspServiceRequestHandler<BuildOnlyDiagnosticIdsResult> |
| [ImportMany] IEnumerable<Lazy<ILspBuildOnlyDiagnostics, ILspBuildOnlyDiagnosticsMetadata>> compilerBuildOnlyDiagnosticsProviders) | ||
| : ILspServiceRequestHandler<BuildOnlyDiagnosticIdsResult> | ||
| { | ||
| public const string BuildOnlyDiagnosticIdsMethodName = "workspace/buildOnlyDiagnosticIds"; |
There was a problem hiding this comment.
is this a well known lsp method? or a roslyn extension?
| public const string BuildOnlyDiagnosticIdsMethodName = "workspace/buildOnlyDiagnosticIds"; | ||
|
|
||
| private readonly DiagnosticAnalyzerInfoCache.SharedGlobalCache _globalCache = globalCache; | ||
| private readonly ImmutableDictionary<string, string[]> _compilerBuildOnlyDiagnosticIds = compilerBuildOnlyDiagnosticsProviders |
There was a problem hiding this comment.
nit: _languageNameToBuildOnlyDiagnosticIds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards dotnet/vscode-csharp#5728
Exposes an LSP API to fetch build-only diagnostic IDs for the given solution snapshot. This API will be invoked from VSCode C# extension on execution of explicit build/rebuild commands to separate out build-only and live diagnostics. See dotnet/vscode-csharp#5728 (comment) for details.