Move csharp decompiler service down to features so it is available in vscode #69501
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
We should make sure that ILSpy is listed in thirdpartynotices.txt to give them appropriate credit. |
| @@ -72,6 +72,7 @@ | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <PackageReference Include="Humanizer.Core" Version="$(HumanizerCoreVersion)" PrivateAssets="compile" /> | |||
| <PackageReference Include="ICSharpCode.Decompiler" Version="$(ICSharpCodeDecompilerVersion)" /> | |||
There was a problem hiding this comment.
cc @jaredpar to advise if this will be a problem for source build
There was a problem hiding this comment.
Guessing this will be a problem but checking.
There was a problem hiding this comment.
Yes, I believe this would be a problem. Features need to be source-buildable.
There was a problem hiding this comment.
You can add the reference to LanguageServer and MEF export the service there, no?
There was a problem hiding this comment.
@tmat Can't add an editor features reference to the language server project.
I was thinking of moving it to the Microsoft.CodeAnalysis.LanguageServer.Protocol.csproj, but it requires dependencies on C# types. While we do technically depend on csharp there, it really isn't supposed to have language specific dependencies. Same issue occurs if I wanted to link it to the Microsoft.CodeAnalysis.LanguageServer project. I can technically do it, but violates language agnostic terms
There was a problem hiding this comment.
Two options:
- Make this service language agnostic
- Add Microsoft.CodeAnalysis.LanguageServer.CSharp
I'd try [1] first. CSharpDecompiledSourceFormattingRule can be moved to Features.CSharp.
There was a problem hiding this comment.
By "this service" I mean the actual decompilation. Could be a new service.
The glue around it, which might be C# specific could be moved to Features.CSharp
There was a problem hiding this comment.
Updated - moved the CSharp bits to CSharp.Features and added an abstraction over the decompilation, moved the actual decompilation implementation to LanguageServer.Protocol
dibarbet
force-pushed
the
vscode_enable_decompiler
branch
from
7fef92a
to
66fc32b
Compare
| namespace Microsoft.CodeAnalysis.CSharp.DecompiledSource | ||
| { | ||
| [ExportLanguageService(typeof(IDecompilationService), LanguageNames.CSharp), Shared] | ||
| internal class CSharpCodeDecompilerDecompilationService : IDecompilationService |
ghost
added this to the 
Resolves dotnet/vscode-csharp#5969