Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escaping and wrapping in vscode hover #69893

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fix escaping and wrapping in vscode hover #69893

merged 1 commit into from
Sep 13, 2023

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Sep 12, 2023 •
edited
Loading

Resolves dotnet/vscode-csharp#6275
Resolves dotnet/vscode-csharp#6328

Now looks like
wrapped_hover

For reference in VS:
wrapped_qi

@dibarbet dibarbet requested a review from a team as a code owner September 12, 2023 00:02
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 12, 2023
@dibarbet
Copy link
Member Author

@dotnet-policy-bot rerun

@dibarbet
Copy link
Member Author

@dotnet-policy-service rerun

@dibarbet dibarbet merged commit f868ca1 into dotnet:main Sep 13, 2023
24 checks passed
@dibarbet dibarbet deleted the hover_fixes branch September 13, 2023 20:44
@ghost ghost added this to the Next milestone Sep 13, 2023
@allisonchou allisonchou mentioned this pull request Sep 18, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhera99 akhera99 akhera99 approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P3
Development

Successfully merging this pull request may close these issues.

C# LSP escapes some characters with backslashes Quick Info window size is strange
3 participants
@dibarbet @akhera99 @Cosifne