Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight improvement to refactoring preview performance for InlineTemporaryCodeRefactoringProvider #70440

Merged

Conversation

ToddGrun
Copy link
Contributor

The GetSemanticModelAsync calls are expensive now as they run source generators when the document they are being requested on doesn't yet have a compilation.

…raryCodeRefactoringProvider

The GetSemanticModelAsync calls are expensive now as they run source generators when the document they are being requested on doesn't yet have a compilation.
@ToddGrun ToddGrun requested a review from a team as a code owner October 18, 2023 20:57
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 18, 2023
@ToddGrun ToddGrun merged commit 35b3c0b into dotnet:main Oct 18, 2023
24 checks passed
@ghost ghost added this to the Next milestone Oct 18, 2023
@jjonescz jjonescz modified the milestones: Next, 17.9 P1 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants