Fix VB intellisense integration test #70756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
genlu
commented
Nov 10, 2023
| options.SetOptionValue(DefaultOptions.ResponsiveCompletionOptionId, false); | ||
| var latencyGuardOptionKey = new EditorOptionKey<bool>("EnableTypingLatencyGuard"); | ||
| options.SetOptionValue(latencyGuardOptionKey, false); | ||
|
|
There was a problem hiding this comment.
@JoshuaBStevens @AmadeusW can you check this? It appears the editor is overwriting our explicit settings somewhere.
There was a problem hiding this comment.
Filed a bug to track the option issue. Meanwhile, let's merge this to get the test fixed
|
@sharwell PTAL, thanks |
CyrusNajmabadi
approved these changes
Nov 13, 2023
sharwell
requested changes
Nov 13, 2023
src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/StateResetInProcess.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Nov 13, 2023
Comment on lines
32
to
+35
| await base.InitializeAsync(); | ||
|
|
||
| // Try disable the responsive completion option again: https://github.com/dotnet/roslyn/issues/70787 | ||
| await TestServices.StateReset.DisableResponsiveCompletion(HangMitigatingCancellationToken); |
There was a problem hiding this comment.
😕 I don't understand how this would make a difference. InitializeAsync is the call which disables responsive non-completion.
There was a problem hiding this comment.
Yea, I don't know. That's tracked by the bug I filed, just want to get this in while we are trying to figure it out
sharwell
approved these changes
Nov 13, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.