Pass through folders for additional files #71061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our workspace model always allowed this at the document level, we just never had a request for it until recently for some XAML support. This adds support for legacy project systems in VS and the base C# extension project system. Changes will need to be made in other repos for the CPS-based project systems to consume the APIs being added here. Partially fixes dotnet#65589
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
jasonmalinowski
removed
the
untriaged
mgoertz-msft
reviewed
Dec 2, 2023
| void AddAdditionalFile(string filePath, bool isInCurrentContext = true); | ||
| void AddAdditionalFile(string filePath, IEnumerable<string> folderNames, bool isInCurrentContext = true); |
There was a problem hiding this comment.
The other folderNames are nullable but not this one. Why?
There was a problem hiding this comment.
If that was also made nullable and optional, then a call of AddAdditionalFile("File.txt") was ambiguous between the two calls, since there's no special logic for the compiler to ignore Obsolete methods in that case. Conveniently the compiler is thinking about that so that's good. 😄
dibarbet
approved these changes
Dec 4, 2023
jasonmalinowski
deleted the
include-folder-information-for-additional-files
branch
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our workspace model always allowed this at the document level, we just never had a request for it until recently for some XAML support. This adds support for legacy project systems in VS and the base C# extension project system. Changes will need to be made in other repos for the CPS-based project systems to consume the APIs being added here.
Partially fixes #65589