Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors LSP server extension assembly loading #71862

Merged
merged 6 commits into from
Feb 7, 2024

Commits on Jan 30, 2024

  1. Refactors LSP server extension assembly loading

      1. Fixes bug where multiple ALCs were created if two extension dlls
         had the same parent directory.
      2. Provides better errors messages if extension paths are malformed.
      3. Normalizes which assembly contributes to the MEF composition if
         provided multiple times
      4. Loads analyzers provided by extensions into the same single extension ALC
    dibarbet committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2a220b2 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Review feedback:

      1. Ensure an assembly only contributes to the MEF catalog once
      2. Prefer the code base to load MEF assemblies
      3. Load devkit dlls via hooking AssemblyLoadContext.Default.Resolve
      4. Misc feedback
    dibarbet committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    fe8e648 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Address more review feedback:

      1. Move duplicate checking to ExtensionAssemblyManager
      2. Store mapping of assembly full name to load context to allow MEF to
         load an assembly by name from the correct load context.
      3. Move devkit assembly resolution out of ExtensionAssemblyManager
      4. Misc feedback
    dibarbet committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    dc3bf43 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b1142c5 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Configuration menu
    Copy the full SHA
    dc40ba3 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Review feedback

    dibarbet committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    cdcf895 View commit details
    Browse the repository at this point in the history