Use generics in syncing code. #72929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
changed the title
CyrusNajmabadi
commented
Apr 8, 2024
| @@ -83,7 +83,7 @@ public async Task TestAssetSynchronization() | |||
| var assetSource = new SimpleAssetSource(workspace.Services.GetService<ISerializerService>(), map); | |||
|
|
|||
| var service = new AssetProvider(sessionId, storage, assetSource, remoteWorkspace.Services.GetService<ISerializerService>()); | |||
| await service.SynchronizeAssetsAsync(AssetPath.FullLookupForTesting, new HashSet<Checksum>(map.Keys), results: null, CancellationToken.None); | |||
| await service.SynchronizeAssetsAsync<object>(AssetPath.FullLookupForTesting, new HashSet<Checksum>(map.Keys), results: null, CancellationToken.None); | |||
There was a problem hiding this comment.
<object> is used when the request is genuinely asking for heterogenous data.
CyrusNajmabadi
commented
Apr 8, 2024
| @@ -39,24 +39,24 @@ internal sealed partial class AssetProvider(Checksum solutionChecksum, SolutionA | |||
| using var _1 = PooledHashSet<Checksum>.GetInstance(out var checksums); | |||
| checksums.Add(checksum); | |||
|
|
|||
| using var _2 = PooledDictionary<Checksum, object>.GetInstance(out var results); | |||
| using var _2 = PooledDictionary<Checksum, T>.GetInstance(out var results); | |||
There was a problem hiding this comment.
the method this is in is already generic. so this now allows that generic information to flow into SynchronizeAssetsAsync
CyrusNajmabadi
commented
Apr 8, 2024
| } | ||
|
|
||
| public override async ValueTask<ImmutableArray<(Checksum checksum, T asset)>> GetAssetsAsync<T>( | ||
| AssetPath assetPath, HashSet<Checksum> checksums, CancellationToken cancellationToken) | ||
| { | ||
| using var _ = PooledDictionary<Checksum, object>.GetInstance(out var results); | ||
| using var _ = PooledDictionary<Checksum, T>.GetInstance(out var results); | ||
|
|
||
| await this.SynchronizeAssetsAsync(assetPath, checksums, results, cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
the method this is in is already generic. so this now allows that generic information to flow into SynchronizeAssetsAsync
ToddGrun
reviewed
Apr 8, 2024
This was referenced Apr 13, 2024
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the added benefit of being able to add logs that can track what type teh caller is asking for.