Remove build-only diagnostics functionality no longer used in product #72941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Apr 8, 2024
| public IWorkspaceService CreateService(HostWorkspaceServices workspaceServices) | ||
| => new BuildOnlyDiagnosticsService(workspaceServices.Workspace); | ||
|
|
||
| private sealed class BuildOnlyDiagnosticsService : IBuildOnlyDiagnosticsService | ||
| { | ||
| private readonly object _gate = new(); | ||
| private readonly Dictionary<DocumentId, ImmutableArray<DiagnosticData>> _documentDiagnostics = []; | ||
| private readonly Dictionary<ProjectId, ImmutableArray<DiagnosticData>> _projectDiagnostics = []; |
There was a problem hiding this comment.
data in this was never read in any product code. only in a single test. remove it, and updated codepaths affected by it.
CyrusNajmabadi
commented
Apr 8, 2024
| @@ -61,18 +56,12 @@ private void OnWorkspaceChanged(object? sender, WorkspaceChangeEventArgs e) | |||
| } | |||
| } | |||
|
|
|||
| public void AddBuildOnlyDiagnostics(Solution solution, ProjectId? projectId, DocumentId? documentId, ImmutableArray<DiagnosticData> diagnostics) | |||
| public void AddBuildOnlyDiagnostics(DocumentId documentId, ImmutableArray<DiagnosticData> diagnostics) | |||
There was a problem hiding this comment.
since nothing was reading the project side, we only need to call this for teh document side of things.
CyrusNajmabadi
commented
Apr 8, 2024
| foreach (var documentId in project.DocumentIds) | ||
| _documentDiagnostics.Remove(documentId); | ||
| } | ||
| } | ||
|
|
||
| public void ClearBuildOnlyDiagnostics(Solution solution, ProjectId? projectId, DocumentId? documentId) | ||
| public void ClearBuildOnlyDiagnostics(Project project, DocumentId? documentId) |
There was a problem hiding this comment.
passing in a project-id here meant 'clear out project diags, and all diags for any document in this project'. So, maintaining that logic here.
CyrusNajmabadi
commented
Apr 8, 2024
| } | ||
| } | ||
|
|
||
| public ImmutableArray<DiagnosticData> GetBuildOnlyDiagnostics(ProjectId projectId) |
There was a problem hiding this comment.
only called in a single test method, no other product code called this.
This was referenced Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.