-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MEF based pull diagnostics #73073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Issues and PRs which have not yet been triaged by a lead
labels
Apr 17, 2024
dotnet-policy-service
bot
added
the
Community
The pull request was submitted by a contributor who is not a Microsoft employee.
label
Apr 17, 2024
3 tasks
dibarbet
reviewed
Apr 19, 2024
...res/LanguageServer/Protocol/Handler/Diagnostics/DiagnosticSources/DiagnosticSourceManager.cs
Outdated
Show resolved
Hide resolved
...res/LanguageServer/Protocol/Handler/Diagnostics/AbstractWorkspaceDiagnosticSourceProvider.cs
Outdated
Show resolved
Hide resolved
etvorun
commented
Apr 22, 2024
...Server/Protocol/Handler/Diagnostics/Public/PublicDocumentNonLocalDiagnosticSourceProvider.cs
Outdated
Show resolved
Hide resolved
etvorun
commented
Apr 22, 2024
...r/Protocol/Handler/Diagnostics/Public/PublicDocumentPullDiagnosticsHandler_IOnInitialized.cs
Outdated
Show resolved
Hide resolved
etvorun
commented
Apr 22, 2024
...anguageServer/Protocol/Handler/Diagnostics/Public/PublicWorkspaceDiagnosticSourceProvider.cs
Outdated
Show resolved
Hide resolved
etvorun
commented
Apr 22, 2024
.../Protocol/Handler/Diagnostics/Public/PublicWorkspacePullDiagnosticsHandler_IOnInitialized.cs
Outdated
Show resolved
Hide resolved
etvorun
commented
Apr 23, 2024
...res/LanguageServer/Protocol/Handler/Diagnostics/DiagnosticSources/DiagnosticSourceManager.cs
Outdated
Show resolved
Hide resolved
etvorun
changed the title
DO NOT MERGE. Implement MEF based pull diagnostics
Implement MEF based pull diagnostics
Apr 23, 2024
etvorun
commented
Apr 23, 2024
...res/LanguageServer/Protocol/Handler/Diagnostics/DiagnosticSources/DiagnosticSourceManager.cs
Outdated
Show resolved
Hide resolved
dibarbet
reviewed
Apr 23, 2024
...res/LanguageServer/Protocol/Handler/Diagnostics/DiagnosticSources/DiagnosticSourceManager.cs
Outdated
Show resolved
Hide resolved
dibarbet
reviewed
Apr 23, 2024
...res/LanguageServer/Protocol/Handler/Diagnostics/DiagnosticSources/DiagnosticSourceManager.cs
Outdated
Show resolved
Hide resolved
...eatures/LanguageServer/Protocol/Handler/Diagnostics/AbstractDocumentPullDiagnosticHandler.cs
Outdated
Show resolved
Hide resolved
...uageServer/Protocol/Handler/Diagnostics/DiagnosticSourceProviders/DiagnosticSourceManager.cs
Outdated
Show resolved
Hide resolved
...uageServer/Protocol/Handler/Diagnostics/DiagnosticSourceProviders/DiagnosticSourceManager.cs
Outdated
Show resolved
Hide resolved
...otocol/Handler/Diagnostics/DiagnosticSourceProviders/DocumentTaskDiagnosticSourceProvider.cs
Outdated
Show resolved
Hide resolved
...ageServer/Protocol/Handler/Diagnostics/DiagnosticSourceProviders/IDiagnosticSourceManager.cs
Outdated
Show resolved
Hide resolved
...ageServer/Protocol/Handler/Diagnostics/DiagnosticSourceProviders/IDiagnosticSourceManager.cs
Outdated
Show resolved
Hide resolved
...ageServer/Protocol/Handler/Diagnostics/DiagnosticSourceProviders/IDiagnosticSourceManager.cs
Outdated
Show resolved
Hide resolved
...geServer/Protocol/Handler/Diagnostics/DiagnosticSourceProviders/IDiagnosticSourceProvider.cs
Outdated
Show resolved
Hide resolved
...geServer/Protocol/Handler/Diagnostics/DiagnosticSourceProviders/IDiagnosticSourceProvider.cs
Outdated
Show resolved
Hide resolved
...iagnostics/DiagnosticSourceProviders/WorkspaceDocumentsAndProjectDiagnosticSourceProvider.cs
Show resolved
Hide resolved
...Server/Protocol/Handler/Diagnostics/Public/PublicDocumentNonLocalDiagnosticSourceProvider.cs
Show resolved
Hide resolved
...s/LanguageServer/Protocol/Handler/Diagnostics/Public/PublicDocumentPullDiagnosticsHandler.cs
Show resolved
Hide resolved
...r/Protocol/Handler/Diagnostics/Public/PublicDocumentPullDiagnosticsHandler_IOnInitialized.cs
Show resolved
Hide resolved
...r/Protocol/Handler/Diagnostics/Public/PublicDocumentPullDiagnosticsHandler_IOnInitialized.cs
Outdated
Show resolved
Hide resolved
.../Protocol/Handler/Diagnostics/Public/PublicWorkspacePullDiagnosticsHandler_IOnInitialized.cs
Outdated
Show resolved
Hide resolved
src/Tools/ExternalAccess/VisualDiagnostics/Contracts/HotReloadRequestContext.cs
Outdated
Show resolved
Hide resolved
src/Tools/ExternalAccess/VisualDiagnostics/Contracts/IHotReloadDiagnosticSource.cs
Outdated
Show resolved
Hide resolved
src/Tools/ExternalAccess/VisualDiagnostics/Internal/HotReloadDiagnosticManager.cs
Outdated
Show resolved
Hide resolved
src/Tools/ExternalAccess/VisualDiagnostics/Internal/HotReloadDiagnosticSource.cs
Outdated
Show resolved
Hide resolved
src/Tools/ExternalAccess/VisualDiagnostics/Internal/HotReloadDiagnosticSourceProvider.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Apr 25, 2024
CyrusNajmabadi
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with making pull diagnostics MEF based
Resolves #72896