Require AddExplicitInterfaceImplementation for adding a type that implements member explicitly #73206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lements member explicitly
dotnet-issue-labeler
bot
added
Area-Interactive
untriaged
src/Features/Core/Portable/EditAndContinue/EditAndContinueCapabilitiesGrantor.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/EditAndContinue/Utilities/Extensions.cs
Outdated
Show resolved
Hide resolved
|
@davidwengier ptal |
davidwengier
approved these changes
Apr 24, 2024
|
@davidwengier The tests do not actually apply the change. Even if they did, the AV is from .NET Framework and it does not occur if the change is the first applied change. |
|
Yeah, I just took the number of tests as an indication of the number of scenarios that could cause an AV. If the ordering is also important, then that could explain it for sure. |
|
Waiting for more customer validation from 17.11 previews before merging. |
|
Is there a corresponding runtime change or a GH issue to light this up for CoreCLR and Mono? /cc @mikelle-rogers |
|
/cc @isadorasophia |
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new row to InterfaceImpl table may case AV on .NET Framework runtime. Report rude edit to prevent that from happening.
The rude edit is reported when
AddExplicitInterfaceImplementationruntime capability is not present.Contributes to fix of https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1452066.
Debugger part: https://devdiv.visualstudio.com/DevDiv/_git/Concord/pullrequest/546202