Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test local functions with goto out of scope #73402

Merged
merged 1 commit into from
May 14, 2024
Merged

Test local functions with goto out of scope #73402

merged 1 commit into from
May 14, 2024

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented May 9, 2024

Resolves #73397.

@jjonescz jjonescz added the Test-Gap Describes a specific feature or scenario that does not have test coverage label May 9, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels May 9, 2024
@jjonescz jjonescz marked this pull request as ready for review May 9, 2024 11:30
@jjonescz jjonescz requested a review from a team as a code owner May 9, 2024 11:30
@jjonescz
Copy link
Member Author

@dotnet/roslyn-compiler for a simple test-only review, thanks

AlekseyTs
AlekseyTs approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@jjonescz jjonescz merged commit cc82c05 into dotnet:main May 14, 2024
24 checks passed
@jjonescz jjonescz deleted the 73397-GotoFromLocalfunc branch May 14, 2024 06:51
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 14, 2024
This was referenced May 16, 2024
Closed
Closed
@Cosifne Cosifne modified the milestones: Next, 17.11 P2 May 28, 2024
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@jaredpar jaredpar jaredpar approved these changes

Assignees
No one assigned
Labels
Area-Compilers Test-Gap Describes a specific feature or scenario that does not have test coverage untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P2
4 participants
@jjonescz @jaredpar @AlekseyTs @Cosifne