Small tweaks to speed up ctrl-click #73442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 13, 2024
| @@ -72,7 +73,8 @@ public async Task<(int? targetPosition, TextSpan tokenSpan)> GetTargetIfControlF | |||
| if (token == default) | |||
| return default; | |||
|
|
|||
| var semanticModel = await document.GetRequiredSemanticModelAsync(cancellationToken).ConfigureAwait(false); | |||
| // We don't need nullable information to compute control flow targets. So avoid expensive work computing this. | |||
| var semanticModel = await document.GetRequiredNullableDisabledSemanticModelAsync(cancellationToken).ConfigureAwait(false); | |||
There was a problem hiding this comment.
debugged through, and there are no other codepaths where we retrieve semantic models for this feature.
CyrusNajmabadi
commented
May 13, 2024
| // don't want to wait on expensive operations like computing source-generators or skeletons if we can avoid | ||
| // it. So first try with a frozen document, then fallback to a normal document. This mirrors how go-to-def | ||
| // works as well. | ||
| return await GetDefinitionLocationWorkerAsync(document.WithFrozenPartialSemantics(cancellationToken)).ConfigureAwait(false) ?? |
There was a problem hiding this comment.
this is what we did in #72714. however, we still have not fully unified all the codepaths involved in navigating to a symbol :'( so there's still the need to update in a one-off manner like this. ideally this can be unified in the future.
|
@ToddGrun ptal |
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.