Report external build errors using the platform's diagnostic brokered #73477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
force-pushed
the
external_errors_support
branch
7 times, most recently
from
9c076e0
to
9972d99
Compare
dibarbet
commented
May 15, 2024
| _externalErrorReporter = new ProjectExternalErrorReporter(ProjectSystemProject.Id, externalErrorReportingPrefix, language, workspaceImpl); | ||
| var projectHierarchyGuid = GetProjectIDGuid(hierarchy); | ||
|
|
||
| _externalErrorReporter = new ProjectExternalErrorReporter(ProjectSystemProject.Id, projectHierarchyGuid, externalErrorReportingPrefix, language, workspaceImpl); |
There was a problem hiding this comment.
hierarchy guid is required for the current project filter to work in the error list.
dibarbet
force-pushed
the
external_errors_support
branch
from
9972d99
to
4f67c89
Compare
dibarbet
commented
May 15, 2024
| { | ||
| using var _ = CodeAnalysis.PooledObjects.ArrayBuilder<DiagnosticData>.GetInstance(out var builder); | ||
|
|
||
| var buildDiagnostics = _buildErrorDiagnosticService.GetBuildErrors().Where(d => d.ProjectId != null && d.Severity != DiagnosticSeverity.Hidden); |
There was a problem hiding this comment.
This never returned diagnostics with LSP on (and cannot). per convo with @CyrusNajmabadi removing this is fine.
dibarbet
force-pushed
the
external_errors_support
branch
from
4f67c89
to
e40e2d4
Compare
dibarbet
commented
May 15, 2024
|
|
||
| namespace Microsoft.CodeAnalysis.Diagnostics; | ||
|
|
||
| [ExportWorkspaceServiceFactory(typeof(IBuildOnlyDiagnosticsService), ServiceLayer.Default), Shared] |
There was a problem hiding this comment.
Dead - does not return build only diagnostic with LSP pull
dibarbet
commented
May 15, 2024
| @@ -116,9 +116,6 @@ internal partial class CodeFixService : ICodeFixService | |||
| var copilotDiagnostics = await GetCopilotDiagnosticsAsync(document, range, priorityProvider.Priority, cancellationToken).ConfigureAwait(false); | |||
| allDiagnostics = allDiagnostics.AddRange(copilotDiagnostics); | |||
|
|
|||
| var buildOnlyDiagnosticsService = document.Project.Solution.Services.GetRequiredService<IBuildOnlyDiagnosticsService>(); | |||
There was a problem hiding this comment.
Dead - this would always get an empty set with LSP pull.
...ols/ExternalAccess/FSharp/Internal/VisualStudio/FSharpProjectExternalErrorReporterFactory.cs
Outdated
Show resolved
Hide resolved
dibarbet
commented
May 15, 2024
| @@ -219,7 +169,7 @@ void computeDiagnosticsToFix(IUIThreadOperationContext context) | |||
| // snapshots. Otherwise, get all diagnostics from the diagnostic service. | |||
| var diagnosticsToFixTask = selectedEntriesOnly | |||
| ? _suppressionStateService.GetSelectedItemsAsync(isAddSuppression, cancellationToken) | |||
| : GetAllBuildDiagnosticsAsync(shouldFixInProject, cancellationToken); | |||
| : Task.FromResult<ImmutableArray<DiagnosticData>>([]); | |||
There was a problem hiding this comment.
didn't feel comfortable removing a ton more things here for servicing. can re-evaluate in main how much (if any) of this type is needed.
src/VisualStudio/Core/Def/TaskList/ProjectExternalErrorReporter.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Show resolved
Hide resolved
dibarbet
commented
May 15, 2024
| /// </summary> | ||
| [Export(typeof(ExternalErrorDiagnosticUpdateSource))] |
There was a problem hiding this comment.
meat of the change in this type. The change here is to report build diagnostics to the editor's diagnostic brokered service. Without this, the build diagnostics reported here go into the void. THis was fine for CPS projects because they are responsible for reporting build errors to the service.
However legacy csproj project system was not updated to do the same, so build diagnostics for legacy csproj went into the void.
This changes our reporter to instead report the build diagnostics to the brokered service. Long term legacy csproj should be updated to use the brokered service themselves, but requires additional work to enable brokered service usage in C++.
src/VisualStudio/Core/Def/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Show resolved
Hide resolved
dibarbet
commented
May 15, 2024
src/VisualStudio/Core/Def/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Show resolved
Hide resolved
src/VisualStudio/Core/Def/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Show resolved
Hide resolved
service instead of via Roslyn
dibarbet
force-pushed
the
external_errors_support
branch
from
e40e2d4
to
8133b7e
Compare
src/VisualStudio/Core/Def/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Show resolved
Hide resolved
src/VisualStudio/Core/Def/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Show resolved
Hide resolved
dibarbet
force-pushed
the
external_errors_support
branch
from
b6bb1fd
to
343a47d
Compare
src/VisualStudio/Core/Def/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Show resolved
Hide resolved
src/VisualStudio/Core/Def/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Show resolved
Hide resolved
src/VisualStudio/Core/Def/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Show resolved
Hide resolved
src/VisualStudio/Core/Def/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Show resolved
Hide resolved
src/VisualStudio/Core/Def/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Show resolved
Hide resolved
src/VisualStudio/Core/Def/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
May 15, 2024
arunchndr
approved these changes
May 15, 2024
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service instead of via Roslyn
Looks like
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2032334