Cache internal objects used by the formatting engine. #73487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
changed the title
CyrusNajmabadi
commented
May 15, 2024
| } | ||
|
|
||
| protected SyntaxFormattingOptions Options { get; } | ||
| protected string Language => _language; | ||
| protected LineFormattingOptions Options { get; } |
There was a problem hiding this comment.
all consumers only need the limited amount of info exposed by LineFormattingOPtions, not the full info in SyntaxFormattingOptions.
CyrusNajmabadi
commented
May 15, 2024
| } | ||
|
|
||
| protected SyntaxFormattingOptions Options { get; } | ||
| protected string Language => _language; |
There was a problem hiding this comment.
Never used. Removed.
ToddGrun
reviewed
May 15, 2024
|
|
||
| protected AbstractTriviaDataFactory(TreeData treeInfo, SyntaxFormattingOptions options) | ||
| protected AbstractTriviaDataFactory(TreeData treeInfo, LineFormattingOptions options) |
There was a problem hiding this comment.
I'll check. But it is exposed as a property on this type.
There was a problem hiding this comment.
Ah, yes, that is used by the derived factories.
This was referenced May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops allocations by 2.2%. Review a commit at a time.