Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable saving source texts to memory mapped files on non-Windows platforms #73628

Closed
wants to merge 2 commits into from
Closed

Disable saving source texts to memory mapped files on non-Windows platforms #73628

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d50dc1
Disable saving source texts to memory mapped files on non-Windows pla…
CyrusNajmabadi May 22, 2024
7020842
Merge branch 'main' into linuxMMF
CyrusNajmabadi Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Workspaces/Core/Portable/Workspace/Solution/VersionSource/RecoverableTextAndVersion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,13 @@ private SourceText Recover(CancellationToken cancellationToken)

private async Task SaveAsync(SourceText text, CancellationToken cancellationToken)
{
// Don't actually attempt to save on non-Windows platforms. On platforms like linux, memory mapped files
// may be a scarse resource that we can end up running out of. We only need to persist to secondary storage
// for 32bit systems, and to enable cheap sharing of data with another process. However, the latter use
// case only applies to VS on windows, so it's ok to not perform here.
if (!PlatformInformation.IsWindows)
return;

Contract.ThrowIfFalse(_storageHandle == null); // Cannot save more than once

var handle = await _storageService.WriteToTemporaryStorageAsync(text, cancellationToken).ConfigureAwait(false);
Expand Down
Loading