Code style options cleanup #73744
Merged
Code style options cleanup #73744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
src/Analyzers/Core/Analyzers/AbstractBuiltInCodeStyleDiagnosticAnalyzer.cs
Show resolved
Hide resolved
sharwell
reviewed
May 29, 2024
sharwell
reviewed
May 29, 2024
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Options/OptionDefinition.cs
Show resolved
Hide resolved
If this isn't already stated on both types, please add. This is def critical info for wrapping ones head around what is going on inside roslyn :D |
CyrusNajmabadi
approved these changes
Jun 5, 2024
This was referenced Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we have two interfaces that represent values of a code style options: ICodeStyleOption (public) and ICodeStyleOption2 (internal).
ICodeStyleOption is only used for options we hand out via legacy public APIs. It is not available in code style layer.
ICodeStyleOption2 should be used throughout Roslyn. The internal values are translated to the public ones at the public entry points.
ICodeStyleOption2 implemented ICodeStyleOption. This change separates these two types entirely, removing the dependency, and cleans up related code.