Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move LanguageServer out of Features directory #73779

Merged
merged 4 commits into from
May 30, 2024
Merged

Move LanguageServer out of Features directory #73779

merged 4 commits into from
May 30, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented May 29, 2024

LanguageServer is not part of Features layer.
This matches layering in the Solution.

@tmat tmat requested review from 333fred and a team as code owners May 29, 2024 23:41
@tmat
Copy link
Member Author

tmat commented May 29, 2024

@dibarbet

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels May 29, 2024
@tmat tmat enabled auto-merge (squash) May 30, 2024 00:03
@tmat tmat disabled auto-merge May 30, 2024 00:04
@tmat
Copy link
Member Author

tmat commented May 30, 2024

Waiting for #73566 ...

@DustinCampbell
Copy link
Member

Waiting for #73566 ...

Thanks @tmat! I've merged.

@tmat tmat enabled auto-merge (squash) May 30, 2024 02:58
DustinCampbell
DustinCampbell approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through all of the files that weren't pure renames. Looks good to me!

@tmat tmat merged commit 12f8968 into dotnet:main May 30, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 30, 2024
@tmat tmat deleted the LSMove branch May 30, 2024 15:57
This was referenced Jun 4, 2024
Closed
Closed
Closed
@jjonescz jjonescz modified the milestones: Next, 17.11 P3 Jun 24, 2024
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
@dibarbet dibarbet mentioned this pull request Jul 25, 2024
Closed
@emmanuel-ferdman emmanuel-ferdman mentioned this pull request Sep 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DustinCampbell DustinCampbell DustinCampbell approved these changes

@333fred 333fred Awaiting requested review from 333fred 333fred is a code owner

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @DustinCampbell @jjonescz