Use EnableCodeStyleSeverity instead of AnalysisLevel to control new diagnostic severity behavior #73843
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
sharwell
changed the title
sharwell
changed the title
|
If I understand this PR correctly then these documentation pages need to be updated for the change, correct? |
|
Yes, those would need to be updated. We'll also need to update the SDK code style build targets to feed the new build property to the compiler. |
| @@ -20,17 +20,6 @@ namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.UseObjectInitializer; | |||
| [Trait(Traits.Feature, Traits.Features.CodeActionsUseObjectInitializer)] | |||
| public partial class UseObjectInitializerTests | |||
| { | |||
| private static async Task TestInRegularAndScriptAsync(string testCode, string fixedCode, OutputKind outputKind = OutputKind.DynamicallyLinkedLibrary) | |||
There was a problem hiding this comment.
Why did this change produce so much churn in the object init tests?
There was a problem hiding this comment.
This analyzer was using an old strategy for code fading that was interfering with some new testing we needed for the feature change. I converted the analyzer to the new style as a separate commit at the beginning of this PR.
…iagnostic severity behavior
sharwell
force-pushed
the
custom-severity
branch
from
4c1d490
to
7cbb1f4
Compare
|
Rebased after reviews completed to apply the fixup commit. |
EnableCodeStyleSeverityinstead ofAnalysisLevelto control new diagnostic severity behaviorFollow-up to #72238