Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax formatting options #74223

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Syntax formatting options #74223

merged 5 commits into from
Jul 8, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 1, 2024 •
edited
Loading

Remove fallbacks.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 1, 2024
@build-analysis build-analysis bot mentioned this pull request Jul 1, 2024
Open
3 tasks
@tmat tmat force-pushed the SyntaxFormattingOptions branch from 23e4d4a to 6a4f2d3 Compare July 2, 2024 15:31
@tmat tmat force-pushed the SyntaxFormattingOptions branch from 6a4f2d3 to 8a1397c Compare July 2, 2024 15:31
@tmat tmat marked this pull request as ready for review July 2, 2024 15:32
@tmat tmat requested a review from a team as a code owner July 2, 2024 15:32
@tmat
Copy link
Member Author

tmat commented Jul 2, 2024

@CyrusNajmabadi ptal

@CyrusNajmabadi
Copy link
Member

Will do when I get into the office :-)

@CyrusNajmabadi
Copy link
Member

Overall seems ok. But will do final pass when this builds :)

@tmat tmat enabled auto-merge (squash) July 2, 2024 18:25
@tmat tmat disabled auto-merge July 2, 2024 19:40
@tmat tmat enabled auto-merge (squash) July 2, 2024 20:01
@tmat tmat merged commit f4fada1 into dotnet:main Jul 8, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 8, 2024
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 9, 2024
@333fred
Merge remote-tracking branch 'upstream/main' into feature/overload-re…
730aea7 
…solution-priority

* upstream/main: (184 commits)
  Disable BuildWithNetFrameworkHostedCompiler (dotnet#74299)
  Avoid using constants for large string literals (dotnet#74305)
  Adjust lowering of a string interpolation in an expression lambda to not use expanded non-array `params` collection in Format/Create calls. (dotnet#74274)
  Consolidate test Span sources (dotnet#74281)
  Allow Document.FilePath to be set to null (dotnet#74290)
  Update Directory.Build.rsp
  Remove fallback options from IdeAnalyzerOptions (dotnet#74235)
  Fix msbuild issue
  Improve parser recovery around nullable types in patterns (dotnet#72805)
  Syntax formatting options (dotnet#74223)
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2490585 (dotnet#74287)
  fix (dotnet#74276)
  Remove more
  fix (dotnet#74237)
  Fix scenario where lightbulbs weren't being displayed
  Reduce closures allocated during invocation of CapturedSymbolReplacement.Replacement (dotnet#74258)
  Reduce allocations in SymbolDeclaredCompilationEvent (dotnet#74250)
  remove type that now serves no purpose
  Remove uncalled method
  Remove more unused code
  ...
@dotnet-bot dotnet-bot mentioned this pull request Jul 10, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request Jul 12, 2024
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.12 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @CyrusNajmabadi @RikkiGibson