Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid more large string constant fields #74307

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Avoid more large string constant fields #74307

merged 2 commits into from
Jul 10, 2024

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Jul 9, 2024

Follow up on #74305.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 9, 2024
@jjonescz jjonescz mentioned this pull request Jul 9, 2024
Merged
@jjonescz jjonescz marked this pull request as ready for review July 9, 2024 16:43
@jjonescz jjonescz requested a review from a team as a code owner July 9, 2024 16:43
jcouv
jcouv approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@jcouv jcouv self-assigned this Jul 9, 2024
@jjonescz jjonescz merged commit 8e69275 into dotnet:main Jul 10, 2024
24 checks passed
@jjonescz jjonescz deleted the TooManyStrings2 branch July 10, 2024 06:52
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 10, 2024
This was referenced Jul 13, 2024
Closed
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
@dotnet-bot dotnet-bot mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@jaredpar jaredpar jaredpar approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.12 P1
Development

Successfully merging this pull request may close these issues.
4 participants
@jjonescz @jaredpar @jcouv @RikkiGibson