Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle span conversions in expression trees #74349

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Handle span conversions in expression trees #74349

merged 3 commits into from
Jul 15, 2024

Conversation

jjonescz
Copy link
Member

Test plan: #73445

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 11, 2024
@jjonescz jjonescz marked this pull request as ready for review July 11, 2024 12:17
@jjonescz jjonescz requested a review from a team as a code owner July 11, 2024 12:17
@jjonescz jjonescz requested review from 333fred and cston July 11, 2024 12:17
@jjonescz
Copy link
Member Author

@cston for the second review, thanks

cston
cston reviewed Jul 12, 2024
View reviewed changes
src/Compilers/CSharp/Test/Emit3/FirstClassSpanTests.cs
var source = """
using System;

C.M(default(object[]));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C.M(default(object[]));

Minor: Consider adding this case to the previous test rather than creating a separate test.

cston
cston reviewed Jul 12, 2024
View reviewed changes
src/Compilers/CSharp/Test/Emit3/FirstClassSpanTests.cs Outdated
using System;
using System.Linq.Expressions;

C.R(() => C.M(default(object[])));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C.R(() => C.M(default(object[])));

Minor: Consider adding this case to the previous test rather than creating a separate test.

@jjonescz jjonescz enabled auto-merge (squash) July 15, 2024 08:02
@jjonescz jjonescz merged commit 3abbfb9 into dotnet:features/FirstClassSpan Jul 15, 2024
24 checks passed
@jjonescz jjonescz deleted the FirstClassSpan-07-ExpressionTrees branch July 15, 2024 09:11
This was referenced Oct 22, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cston cston cston approved these changes

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
Area-Compilers New Feature - First-class Span Types untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjonescz @333fred @cston