Don't bring up completion when deleting in an xml doc comment's text #74558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C# backspace still brings up completion in xml doc comment attribute name/values, but not in xmltext or xmltag contexts (completion in the xmltag context behavior seems a bit buggy, so intentionally not bringing up in that context). VB backspace actually behave a bit better in the xmldoc context, but had a separate issue in attribute value contexts which is addressed also. Addresses dotnet#74417
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -129,6 +129,10 @@ public override bool IsInsertionTrigger(SourceText text, int characterPosition, | |||
| // too aggressive at suggesting tags, so exit early before degrading the experience | |||
| return null; | |||
| } | |||
| else if (trigger.Kind == CompletionTriggerKind.Deletion) | |||
CyrusNajmabadi
approved these changes
Jul 25, 2024
dibarbet
approved these changes
Jul 25, 2024
3 tasks
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C# backspace still brings up completion in xml doc comment attribute name/values, but not in xmltext or xmltag contexts (completion in the xmltag context behavior seems a bit buggy, so intentionally not bringing up in that context).
VB backspace actually behave a bit better in the xmldoc context, but had a separate issue in attribute value contexts which is addressed also.
Addresses #74417