Change SyntaxEquivalence.AreEquivalent to use a more appropriate pooling mechanism for the stack it uses to walk trees. #74610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing mechanism for the stack it uses to walk trees. The scrolling speedometer test indicates this method's pooling mechanism isn't working great for large files. Specifically, ArrayBuilder instances aren't returned to their pool once their length exceeds 128 items. For even relatively large files, I'm seeing this exceeded in this context. Instead, I've switched this code to just use a pooled Stack. This was accounting for about 1.1% of allocations in the typing scenario for the scrolling speedometer test.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
CyrusNajmabadi
approved these changes
Jul 30, 2024
|
tests failing, need to investigate |
…ance that it won't be empty
|
Duh. There's a code path where the stack isn't null when hitting the finally, so it needs to be cleared before being placed back in the pool. In reply to: 2259388249 |
| @@ -117,7 +121,8 @@ private static bool AreEquivalentRecursive(GreenNode? before, GreenNode? after, | |||
| } | |||
| finally | |||
| { | |||
| stack.Free(); | |||
| stack.Clear(); | |||
| s_equivalenceCheckStack.Free(stack); | |||
There was a problem hiding this comment.
is there not FreeAndClear/ClearAndFree?
There was a problem hiding this comment.
That's defined at the workspace level
There was a problem hiding this comment.
I would be fine to move that down if you wanted.
There was a problem hiding this comment.
Though I will point out that those helpers stop returning pooled objects after they get to 512 items. That might not work well here either.
|
@dotnet/roslyn-compiler -- ready for review |
333fred
approved these changes
Jul 31, 2024
|
@dotnet/roslyn-compiler for 2nd review |
jjonescz
approved these changes
Aug 1, 2024
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scrolling speedometer test indicates this method's pooling mechanism isn't working great for large files. Specifically, ArrayBuilder instances aren't returned to their pool once their length exceeds 128 items. For even relatively large files, I'm seeing this exceeded in this context.
Instead, I've switched this code to just use a pooled Stack. This was accounting for about 1.1% of allocations in the typing scenario for the scrolling speedometer test.
*** relevant allocations from the typing scenario in the scrolling speedometer test ***
