Revise usage of <code> tag in IOperation docs
#74719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
the
Community
CyrusNajmabadi
approved these changes
Aug 12, 2024
| @@ -2975,8 +2975,8 @@ public interface IRecursivePatternOperation : IPatternOperation | |||
| /// </summary> | |||
| ITypeSymbol MatchedType { get; } | |||
| /// <summary> | |||
| /// The symbol, if any, used for the fetching values for subpatterns. This is either a <code>Deconstruct</code> | |||
| /// method, the type <code>System.Runtime.CompilerServices.ITuple</code>, or null (for example, in | |||
There was a problem hiding this comment.
should this just be a cref?
should the null be a langword?
333fred
approved these changes
Aug 12, 2024
cston
approved these changes
Aug 12, 2024
|
Can someone restart failed CI pipelines please? Or just straight up merge, there are no code changes anyway |
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed, that in all places in
IOperationdoc<code>tag was used incorrectly. In many cases<see langword...should be used instead. In several places inline code (<c>) looks a lot betterExample:
Before:
After:
