Log messages for Test Results #75084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
dibarbet
approved these changes
Sep 12, 2024
| messageBuilder.AppendLine(IndentString($"{LanguageServerResources.Message}:", 4)); | ||
| messageBuilder.AppendLine(IndentString(result.ErrorMessage, 8)); | ||
| } | ||
|
|
||
| if (!string.IsNullOrWhiteSpace(result.ErrorStackTrace)) | ||
| { | ||
| messageBuilder.AppendLine(); |
There was a problem hiding this comment.
I think this will append an empty line between the msg and stack trace, which IIRC is why I appended only once above. Maybe not the biggest issue but I believe that was why it was written that way
| messageBuilder.AppendLine(value: IndentString($"{LanguageServerResources.Stack_Trace}:", 4)); | ||
| messageBuilder.AppendLine(IndentString(result.ErrorStackTrace, 8)); | ||
| } | ||
|
|
||
| var standardOutputMessages = GetTestMessages(result.Messages, TestResultMessage.StandardOutCategory); |
There was a problem hiding this comment.
do you have a screenshot of what it looks like?
There was a problem hiding this comment.
I updated the description with some output. Let me see if I can get output and error messages.
There was a problem hiding this comment.
Ah, ok. So just one new line at the top and we squish everything together.
Starting test run
[Failed] Microsoft.CodeAnalysis.Tools.Tests.Analyzers.ThirdPartyAnalyzerFormatterTests.TestLoadingAllAnalyzers_LoadsDependenciesFromAllSearchPaths
Message:
System.Exception : This is an error message
Stack Trace:
at Microsoft.CodeAnalysis.Tools.Tests.Analyzers.ThirdPartyAnalyzerFormatterTests.TestLoadingAllAnalyzers_LoadsDependenciesFromAllSearchPaths() in c:\Users\jorobich\source\format\tests\Analyzers\ThirdPartyAnalyzerFormatterTests.cs:line 218
--- End of stack trace from previous location ---
Standard Output Messages:
Determining projects to restore...
All projects are up-to-date for restore.
==== Summary ====
Failed! - Failed: 1, Passed: 0, Skipped: 0, Total: 1, Duration: 9s
dibarbet
approved these changes
Sep 12, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our logging to match the console logger from the vstest.console runner. See https://github.com/Evangelink/vstest/blob/85ae981180b515d79721266a19a7aa31c30828c5/src/vstest.console/Internal/ConsoleLogger.cs#L295
Resolves http://github.com/dotnet/vscode-csharp/issues/6221
Output looks like: