Allow <code> in DocComments to render as a block in Hover response #75215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
Note that this feature was originally implemented in #35667 for Visual Studio. I believe the change here is only related to LSP clients. Can we get tests added for the new behavior? |
3 tasks
dibarbet
reviewed
Sep 24, 2024
There was a problem hiding this comment.
lgtm, pending requested test
https://github.com/dotnet/roslyn/blob/main/src/LanguageServer/ProtocolUnitTests/Hover/HoverTests.cs is probably the right place
dibarbet
approved these changes
Sep 24, 2024
Co-authored-by: David Barbet <[email protected]>
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed in #75181,
<code>from DocComment always renders inline even if it represents a block of code.Before:
After:
In order to have highlighting, we will need to pass along the code blocks
langattribute with the TaggedText.