Don't update xaml tool #75348
Merged
Don't update xaml tool #75348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
akhera99
approved these changes
Oct 2, 2024
jjonescz
approved these changes
Oct 2, 2024
RikkiGibson
approved these changes
Oct 3, 2024
akhera99
added a commit
that referenced
this pull request
Oct 3, 2024
* Don't update xaml tool (#75348) * Revert "Don't update xaml tool (#75348)" This reverts commit 8903f4b. --------- Co-authored-by: Shen Chen <[email protected]> Co-authored-by: Ankita Khera <[email protected]>
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/roslyn-tools#1430 set updateXamlRoslynVersion default to be true.
It should fix https://dev.azure.com/dnceng/internal/_build/results?buildId=2550417&view=results
In old release branch this
/src/Xaml/Versions.propsdoesn't exist.So we need to pass that parameter.