Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bail out gracefully when we can't find service #75457

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner October 9, 2024 20:26
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 9, 2024
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JoeRobich
Copy link
Member

If the problem is that the fixer is being loaded from the CodeStyle analyzers, we should not be loading them in the IDE as of this change. #75250

@CyrusNajmabadi CyrusNajmabadi merged commit 001c0f3 into dotnet:main Oct 9, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 9, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the genVarService branch October 9, 2024 23:02
@akhera99 akhera99 modified the milestones: Next, 17.13 P1 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullRef in GenerateVariable.CSharpGenerateVariableCodeFixProvider.GetCodeActionsAsync
5 participants