Unify collection expression cycle handling #75464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
cston
reviewed
Oct 14, 2024
| @@ -13878,16 +13878,7 @@ static void Test(params MyCollection a) | |||
| Diagnostic(ErrorCode.ERR_ParamsCollectionInfiniteChainOfConstructorCalls, "[1]").WithArguments("MyCollection", "MyCollection.MyCollection(params MyCollection)").WithLocation(21, 14), | |||
| // (21,15): error CS9223: Creation of params collection 'MyCollection' results in an infinite chain of invocation of constructor 'MyCollection.MyCollection(params MyCollection)'. | |||
| // Test([1]); | |||
There was a problem hiding this comment.
Is this comment referring to the correct line?
cston
reviewed
Oct 14, 2024
| Debug.Assert((collectionCreation is BoundNewT && !isExpanded && constructor is null) || | ||
| (collectionCreation is BoundObjectCreationExpression creation && creation.Expanded == isExpanded && creation.Constructor == constructor)); | ||
|
|
||
| if (collectionCreation.HasErrors) |
There was a problem hiding this comment.
It's not needed, but it prevents cascading diagnostics. For example, in a call like Test(2, 3);, the cycle error would be reported on Test(2, 3), 2, and 3.
cston
approved these changes
Oct 14, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #75024.