From b4be77b69d426f3e83777b024ee7d98e325bf593 Mon Sep 17 00:00:00 2001
From: Kunal Pathak <Kunal.Pathak@microsoft.com>
Date: Wed, 20 Sep 2023 10:17:22 -0700
Subject: [PATCH] Update the assert for BlendVariable (#92183)

* Update the assert for BlendVariable

* Add test cases

* Add Sse41.IsSupported check
---
 src/coreclr/jit/emitxarch.cpp                 |  9 +++-
 .../JitBlue/Runtime_91798/Runtime_91798.cs    | 43 +++++++++++++++++++
 .../Runtime_91798/Runtime_91798.csproj        |  9 ++++
 3 files changed, 59 insertions(+), 2 deletions(-)
 create mode 100644 src/tests/JIT/Regression/JitBlue/Runtime_91798/Runtime_91798.cs
 create mode 100644 src/tests/JIT/Regression/JitBlue/Runtime_91798/Runtime_91798.csproj

diff --git a/src/coreclr/jit/emitxarch.cpp b/src/coreclr/jit/emitxarch.cpp
index c1d7e2df5d423..65789413500cd 100644
--- a/src/coreclr/jit/emitxarch.cpp
+++ b/src/coreclr/jit/emitxarch.cpp
@@ -8609,9 +8609,14 @@ void emitter::emitIns_SIMD_R_R_R_R(
         // SSE4.1 blendv* hardcode the mask vector (op3) in XMM0
         emitIns_Mov(INS_movaps, attr, REG_XMM0, op3Reg, /* canSkip */ true);
 
-        // Ensure we aren't overwriting op2 or oop3 (which should be REG_XMM0)
+        // Ensure we aren't overwriting op2 or op3 (which should be REG_XMM0)
         assert((op2Reg != targetReg) || (op1Reg == targetReg));
-        assert(targetReg != REG_XMM0);
+
+        // If targetReg == REG_XMM0, it means that op3 was last use and we decided to
+        // reuse REG_XMM0 for destination i.e. targetReg. In such case, make sure
+        // that XMM0 value after the (op3Reg -> XMM0) move done above is not
+        // overwritten by op1Reg.
+        assert((targetReg != REG_XMM0) || (op1Reg == op3Reg));
 
         emitIns_Mov(INS_movaps, attr, targetReg, op1Reg, /* canSkip */ true);
         emitIns_R_R(ins, attr, targetReg, op2Reg);
diff --git a/src/tests/JIT/Regression/JitBlue/Runtime_91798/Runtime_91798.cs b/src/tests/JIT/Regression/JitBlue/Runtime_91798/Runtime_91798.cs
new file mode 100644
index 0000000000000..3e23f98734229
--- /dev/null
+++ b/src/tests/JIT/Regression/JitBlue/Runtime_91798/Runtime_91798.cs
@@ -0,0 +1,43 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+//
+// There was an issue with Sse41.BlendVariable where we might reuse XMM0
+// for targetReg.
+
+using System;
+using System.Runtime.CompilerServices;
+using System.Runtime.Intrinsics;
+using System.Runtime.Intrinsics.X86;
+using Xunit;
+
+public class TestClass_91798
+{
+    Vector128<uint> v128_uint_75 = Vector128.Create((uint)2, 1, 0, 1);
+
+    [MethodImpl(MethodImplOptions.NoInlining)]
+    public Vector128<uint> Method0()
+    {
+        return Sse41.BlendVariable(v128_uint_75, Vector128<uint>.One, v128_uint_75);
+    }
+
+    [Fact]
+    public static void TestEntryPoint()
+    {
+        if (Sse41.IsSupported)
+        {
+            TestClass_91798 obj = new TestClass_91798();
+            obj.Method0();
+        }
+    }
+}
+/*
+Environment:
+
+set DOTNET_EnableSSE42=0
+
+Assert failure(PID 8884 [0x000022b4], Thread: 14588 [0x38fc]): Assertion failed '(targetReg != REG_XMM0)' in 'TestClass_91798:Method0():System.Runtime.Intrinsics.Vector128`1[uint]:this' during 'Generate code' (IL size 23; hash 0x557a6266; FullOpts)
+
+    File: D:\git\runtime2\src\coreclr\jit\emitxarch.cpp Line: 8612
+    Image: d:\git\runtime2\artifacts\tests\coreclr\windows.x64.Checked\tests\Core_Root\corerun.exe
+*/
+
diff --git a/src/tests/JIT/Regression/JitBlue/Runtime_91798/Runtime_91798.csproj b/src/tests/JIT/Regression/JitBlue/Runtime_91798/Runtime_91798.csproj
new file mode 100644
index 0000000000000..9f6a0b76d8caf
--- /dev/null
+++ b/src/tests/JIT/Regression/JitBlue/Runtime_91798/Runtime_91798.csproj
@@ -0,0 +1,9 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <Optimize>True</Optimize>
+  </PropertyGroup>
+  <ItemGroup>
+    <Compile Include="$(MSBuildProjectName).cs" />
+    <CLRTestEnvironmentVariable Include="DOTNET_EnableSSE42" Value="0" />
+  </ItemGroup>
+</Project>