Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About 40% regression or the XmlDocument performance test Create() #10214

Closed
maryamariyan opened this issue Apr 21, 2018 · 3 comments
Closed

About 40% regression or the XmlDocument performance test Create() #10214

maryamariyan opened this issue Apr 21, 2018 · 3 comments

Comments

@maryamariyan
Copy link
Member

The Regression for the XmlDocument performance test Create() is illustrated in the chart below.

screen shot 2018-04-20 at 6 03 33 pm

Refer to benchview for more details.

@krwq I was looking at the Marvin hashcode commit dotnet/corefx@697e2b9 you submitted in January and it seems when instantiating XmlDocument it suddenly regressed. Was this by design or not intentional?

Overall the regression is about 45% on Linux (and around 30% on Windows). Although the regression seems to have started from January, there have been some ups and downs since so not exactly sure if I can find the exact root cause for the overall regression here in a straightforward way.

The test Create() as seen here, just attempts to create new XmlDocument() multiple times.

cc: @kouvel @danmosemsft

@maryamariyan maryamariyan changed the title About 40% performance regression for XmlDocument initialization About 40% performance regression for Create() test for XmlDocument Apr 21, 2018
@maryamariyan maryamariyan changed the title About 40% performance regression for Create() test for XmlDocument About 40% performance regression for Create() perf test for XmlDocument Apr 21, 2018
@maryamariyan maryamariyan changed the title About 40% performance regression for Create() perf test for XmlDocument About 40% regression or the XmlDocument performance test Create() Apr 21, 2018
@RussKeldorph
Copy link
Contributor

@maryamariyan Can you clarify why this was opened in coreclr instead of corefx?

@jkotas
Copy link
Member

jkotas commented Apr 21, 2018

This issue was moved to dotnet/corefx#29260

@jkotas jkotas closed this as completed Apr 21, 2018
@maryamariyan
Copy link
Member Author

maryamariyan commented Apr 21, 2018

@RussKeldorph my bad - wrong repo.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants