Build FAILED after #106209 PR (Implement type name resolution for ILLink analyzer)

[AlexRadch]

Description

After I installed the new .NET SDK 9.0.100-preview.7.24407.12 globally, the runtime build was successful.

Can not build runtime after #106209 PR (Implement type name resolution for ILLink analyzer)

With the next log:

  System.Private.CoreLib -> C:\AProj\runtime\artifacts\bin\System.Private.CoreLib\ref\Release\net9.0\System.Private.CoreLib.dll

Build FAILED.

CSC : error CS8032: An instance of analyzer ILLink.RoslynAnalyzer.RequiresUnreferencedCodeAnalyzer cannot be created from C:\AProj\runtime\artifacts\bin\ILLink.RoslynAnalyzer\Debug\netstandard2.0\ILLink.RoslynAnalyzer.dll : Could not load file or assembly 'System.Collections.Immutable, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The specified file cannot be found. [C:\AProj\runtime\src\coreclr\System.Private.CoreLib\System.Private.CoreLib.csproj]
CSC : error CS8032: An instance of analyzer ILLink.RoslynAnalyzer.RequiresAssemblyFilesAnalyzer cannot be created from C:\AProj\runtime\artifacts\bin\ILLink.RoslynAnalyzer\Debug\netstandard2.0\ILLink.RoslynAnalyzer.dll : Could not load file or assembly 'System.Collections.Immutable, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The specified file cannot be found. [C:\AProj\runtime\src\coreclr\System.Private.CoreLib\System.Private.CoreLib.csproj]
CSC : error CS8032: An instance of analyzer ILLink.RoslynAnalyzer.COMAnalyzer cannot be created from C:\AProj\runtime\artifacts\bin\ILLink.RoslynAnalyzer\Debug\netstandard2.0\ILLink.RoslynAnalyzer.dll : Could not load file or assembly 'System.Collections.Immutable, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The specified file cannot be found. [C:\AProj\runtime\src\coreclr\System.Private.CoreLib\System.Private.CoreLib.csproj]
CSC : error CS8032: An instance of analyzer ILLink.RoslynAnalyzer.DynamicallyAccessedMembersAnalyzer cannot be created from C:\AProj\runtime\artifacts\bin\ILLink.RoslynAnalyzer\Debug\netstandard2.0\ILLink.RoslynAnalyzer.dll : Could not load file or assembly 'System.Collections.Immutable, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The specified file cannot be found. [C:\AProj\runtime\src\coreclr\System.Private.CoreLib\System.Private.CoreLib.csproj]
CSC : error CS8032: An instance of analyzer ILLink.RoslynAnalyzer.RequiresDynamicCodeAnalyzer cannot be created from C:\AProj\runtime\artifacts\bin\ILLink.RoslynAnalyzer\Debug\netstandard2.0\ILLink.RoslynAnalyzer.dll : Could not load file or assembly 'System.Collections.Immutable, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The specified file cannot be found. [C:\AProj\runtime\src\coreclr\System.Private.CoreLib\System.Private.CoreLib.csproj]
    0 Warning(s)
    5 Error(s)

Time Elapsed 00:01:14.99
Build failed with exit code 1. Check errors above.
Some builds failed:
        Configuration: Debug, Architecture: x64

Reproduction Steps

git clean -xdf
git pull upstream main
build.cmd clr+libs -rc Release

Expected behavior

Successful Build.

Actual behavior

Build FAILED

Regression?

Yes

Known Workarounds

1. After I removed the .Net 9 global SDK, the build was successful.
2. Or use runtime before this PR.

Configuration

.NET 9.0.100-preview.6.24328.19 installed globally
Windows 10
x64

Other information

No response

[huoyaoyuan]

I can also reproduce this in VS.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

[ViktorHofer]

I can reproduce this as well. Uninstalling the global SDK helped in my case.

[pavelsavara]

same here, deleting my local dotnet installation helped.

[sbomer]

I haven't been able to reproduce this build failure locally. @ViktorHofer you suggested in #106209 (comment) that the reference to System.Reflection.Metadata might be too new - can you elaborate? I would have expected the analyzer reference to load these from nuget when building locally.

[sbomer]

@huoyaoyuan would you be able to share repro instructions that hit this in VS?

[AlexRadch]

After I removed the .Net 9 global SDK, the build was successful.

[sbomer]

Odd, that suggests to me that the build was picking up an older version of the global SDK, but shouldn't that be prevented by the version in global.json? More specific repro steps would be helpful.

[elinor-fung]

I'd guess you want SystemReflectionMetadataToolsetVersion instead of SystemReflectionMetadataVersion. I know for HostModel and other things that get loaded in build, we keep the version <= than that in MSBuild/SDK because MSBuild uses those same dependencies and has binding redirects that can end up in some sort of mismatch.

[sbomer]

Unfortunately, that version doesn't have TypeNameParseOptions (from .NET 9) that the change needs. I think you're right that it's due to some version mismatch with the MSBuild/SDK dependencies, or maybe it's not finding the dependency at all when running on full framework MSBuild.

[AlexRadch]

Odd, that suggests to me that the build was picking up an older version of the global SDK, but shouldn't that be prevented by the version in global.json? More specific repro steps would be helpful.

When I install the latest .Net 9.0.100-preview.6.24328.19 globally, then the build FAILS.

[sbomer]

@elinor-fung pointed me to #97021 (comment) which looks like it describes the problem here. I see binding redirects that redirect to the 8.0 version of System.Collections.Immutable, and per the linked comment it sounds like any references to a 9.0.0 version will cause problems until the binding redirects are updated.

[noahfalk]

More specific repro steps would be helpful.

If it helps my repro of this:

1. These SDKs were already installed:

C:\git\runtime3>dotnet --list-sdks
C:\Program Files\dotnet
8.0.108 [C:\Program Files\dotnet\sdk]
8.0.303 [C:\Program Files\dotnet\sdk]
8.0.400-preview.0.24324.5 [C:\Program Files\dotnet\sdk]
9.0.100-preview.6.24328.19 [C:\Program Files\dotnet\sdk]

2. Clone the runtime repo and pull from https://github.com/dotnet/runtime main

C:\git\runtime3>git log
commit ec7fd04 (HEAD -> main, upstream/main, origin/main, master)
Author: Viktor Hofer [email protected]
Date: Tue Aug 13 19:29:08 2024 +0200

3. Build libs

build.cmd libs

[sbomer]

Thanks, I was able to repro it with a global SDK install. I'll revert the change and probably wait for .NET 10 to make the fix.

[huoyaoyuan]

@huoyaoyuan would you be able to share repro instructions that hit this in VS?

Just pulled the change in VS, and invoke "Rebuild" for CoreLib. It's now failing.

[sbomer]

The change has been reverted: #106343

[AlexRadch]

After I installed the new .NET SDK 9.0.100-preview.7.24407.12 globally, the runtime build was successful.