-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License metadata on windows runtime nuget packages is wrong #108905
Comments
Tagging subscribers to this area: @dotnet/area-meta |
cc @richlander |
Thanks for the report! You are correct. That doesn't seem right. We'll get this fixed in I'll talk to some folks. |
cc @dotnet/area-infrastructure-libraries for awareness |
Status:
It would be best to wait for final guidance before making any license changes to the artifacts we produce/publish. |
According to WPF docs, |
That's good context. We'd prefer not to have to use the whole VS license. I think that's actually what we were doing before. Either way, we'll sort this out. |
We now have more clarity on next steps:
@leecow -- Who should be assigned this work? [1] https://github.com/dotnet/core/blob/main/license-information-windows.md |
We merged the referenced PR. @leecow -- who would be responsible for updated packages to use the correct license? |
Is the work for individual repos to implement "All Windows artifacts (runtime, aspnetcore, sdk) should reference [1] as their license", or are there also license references that are wrong? |
I just wrote up some guidance on our model: https://github.com/dotnet/runtime/blob/main/docs/project/licensing-assets.md I hope this is clearer than what I wrote before. I think some of what I wrote before was also wrong. |
According to the
LICENSE.TXT
insidedotnet-sdk-8.0.403-win-x64.zip
/dotnet-runtime-8.0.10-win-x64.zip
the license of those binaries is the .NET Library License.But the license fields on https://www.nuget.org/packages/Microsoft.NETCore.App.Runtime.win-x64/8.0.10 and https://www.nuget.org/packages/Microsoft.WindowsDesktop.App.Runtime.win-x64/8.0.10 say
MIT
even though they contain the offending binaries:runtimes/win-x64/native/Microsoft.DiaSymReader.Native.amd64.dll
,runtimes/win-x64/native/PresentationNative_cor3.dll
etc.Also, there is the question of whether the license is even
.NET Library License
if it contains files likeruntimes/win-x64/native/D3DCompiler_47_cor3.dll
andruntimes/win-x64/native/vcruntime140_cor3.dll
which according to https://github.com/dotnet/core/blob/main/license-information-windows.md are licensed under Windows SDK License and Microsoft Visual C++ Runtime Software License, respectively.The text was updated successfully, but these errors were encountered: