Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS automatically changing solution and csproj #14257

Closed
krwq opened this issue Feb 19, 2015 · 2 comments
Closed

VS automatically changing solution and csproj #14257

krwq opened this issue Feb 19, 2015 · 2 comments
Assignees
Milestone

Comments

@krwq
Copy link
Member

krwq commented Feb 19, 2015

What are your thoughts about VS automatically changing stuff?

I.e: dotnet/corefx#954 VS updated version info. Also it removed new line character in the end of csproj (I removed this this change).

Should we keep that kind of changes or revert them?

I don't have strong opinion on that although I generally think that easier solution is always better: we should not manually change csproj & sln files so if VS wants to change it I would let it.

@akoeplinger
Copy link
Member

+1. It would be nice though if this could be done for all .csproj's in a single pass so it doesn't show up randomly in a changeset (I guess this might only be possible once the VS2015 version number doesn't change anymore?).

@weshaggard
Copy link
Member

The solution files are always bad about this which is why I've never really liked having them checked in (however I've lost that battle :)). I suspect we are going to continuously fight each other on the version as everyone will be using a different version of VS. Personally I would just undo those changes locally if that is the only change in the file. If there other changes in the file then I would submit it along with the other changes.

As for other files like csproj files we should definitely try to have a base and let the common tooling format it as it will and not fight against that.

@krwq krwq closed this as completed Apr 21, 2015
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rtm milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants