Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Official build break: CoreCLR asset path missing '/' in installer subset #2053

Closed
dagood opened this issue Jan 23, 2020 · 1 comment · Fixed by #2083
Closed

Official build break: CoreCLR asset path missing '/' in installer subset #2053

dagood opened this issue Jan 23, 2020 · 1 comment · Fixed by #2083
Labels
area-Infrastructure blocking-official-build untriaged New issue has not been triaged by the area owner

Comments

@dagood
Copy link
Member

dagood commented Jan 23, 2020

Example:

https://dev.azure.com/dnceng/internal/_build/results?buildId=493349&view=logs&j=03f0c49c-0e1a-5166-19f6-fc865fe47495&t=8ffb5fe8-216f-590f-db83-b0e95984e140&l=1033

F:\workspace\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.20071.3\tools\Sign.proj(81,5): error MSB4018: System.IO.FileNotFoundException: Could not find file 'F:\workspace\_work\1\s\artifacts\transport\coreclrSystem.Private.CoreLib.dll'.

Note transport\coreclrSystem.Private.CoreLib.dll

I think this is because of missing normalization here (#1934):

runtime/eng/liveBuilds.targets

Lines 21 to 23 in fd7a5e8

<!-- Honor the RuntimeArtifactsPath property. -->
<CoreCLRArtifactsPath Condition="'$(CoreCLRArtifactsPath)' == ''">$(RuntimeArtifactsPath)</CoreCLRArtifactsPath>
<MonoArtifactsPath Condition="'$(MonoArtifactsPath)' == ''">$(RuntimeArtifactsPath)</MonoArtifactsPath>

Because that variable is used in signing here:

runtime/eng/Signing.props

Line 39 in fd7a5e8

<ItemsToSign Include="$(CoreCLRArtifactsPath)System.Private.CoreLib.dll" />

I think normalizing would fix the break.

@dotnet/runtime-infrastructure
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-coreclr untriaged New issue has not been triaged by the area owner labels Jan 23, 2020
@jashook jashook mentioned this issue Jan 23, 2020
Closed
@jaredpar
Copy link
Member

@akoeplinger can you fix this up? Seems to be fallout from the Mono CI PR

akoeplinger added a commit to akoeplinger/runtime that referenced this issue Jan 23, 2020
@akoeplinger
Make sure CoreCLRArtifactsPath/MonoArtifactsPath has trailing slash
0a62cf2 
Addresses the official build break caused by the Mono CI PR.

Fixes dotnet#2053
@akoeplinger akoeplinger mentioned this issue Jan 23, 2020
Merged
akoeplinger added a commit that referenced this issue Jan 23, 2020
@akoeplinger
Make sure CoreCLRArtifactsPath/MonoArtifactsPath has trailing slash (#…
98f58b7 
…2083)

* Make sure CoreCLRArtifactsPath/MonoArtifactsPath has trailing slash

Addresses the official build break caused by the Mono CI PR.

Fixes #2053

* Handle empty RuntimeArtifactsPath
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure blocking-official-build untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure CoreCLRArtifactsPath/MonoArtifactsPath has trailing slash akoeplinger/runtime
3 participants
@jaredpar @dagood @Dotnet-GitSync-Bot